(chore): Fix the reference to the webpack types #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacButko
approved these changes
Jun 22, 2022
|
Error: Error while trying to collect info before merging fix-webpack-references into master. TypeError: directoryUrl must be a string or an url, received undefined
at assertAndNormalizeDirectoryUrl (file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@jsenv/filesystem/src/assertAndNormalizeDirectoryUrl.js:23:11)
at generateFileSizeReport (file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/node_modules/@jsenv/file-size-impact/src/generateFileSizeReport.js:26:22)
at file:///home/runner/work/openmrs-esm-core/openmrs-esm-core/tools/size-generator.mjs:41:37
Generated by @jsenv/file-size-impact during Report bundle size#2544172166 on 6ce9f9f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
In #448, I removed some conflicting type definitions. However, the way I did this resulted in a package that's dependent on a certain dependency structure, i.e., the structure of the monorepo. This breaks the ability of this code to be built outside of the monorepo. The App Shell, however, needs to be buildable outside of the monorepo for the
openmrs buildcommand to work properly, so this shifts to using proper dependency resolution for the types rather than a file path.Marked as a chore as this is a tooling fix rather than an API change.
Screenshots
Related Issue
Other